fix: enable message receipts by default; closes #132 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerlepine
added
🐛 Bug
spencerlepine
force-pushed
the
spenlep/issue-132
branch
2 times, most recently
from
670ef09 to
c92c3ea
Compare
spencerlepine
force-pushed
the
spenlep/issue-132
branch
from
c92c3ea to
963f211
Compare
spencerlepine
requested review from
mliao95 and
haomingli2020
and removed request for
a team
spencerlepine
changed the title
| if (!shouldSendMessageReceipts) { | ||
| GlobalConfig.removeFeatureFlag(FEATURES.MESSAGE_RECEIPTS_ENABLED); | ||
| } | ||
| GlobalConfig.updateThrottleTime(1000); |
There was a problem hiding this comment.
where does this 1000ms throttle time come from?
There was a problem hiding this comment.
Looks like this was just copy/pasted from the internal code. No test coverage so it looks like the behavior won't change it either way
The README and code will default to 5000 [ref]
spenlep-amzn
requested review from
spenlep-amzn and
haomingli2020
and removed request for
spenlep-amzn
haomingli2020
approved these changes
Mar 4, 2024
mliao95
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#132
Description of changes:
Make enable message receipts by default without calling setGlobalConfig()
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.